fix(search): filter search results by docs version and show version b…#502
Open
Marias03 wants to merge 2 commits into
Open
fix(search): filter search results by docs version and show version b…#502Marias03 wants to merge 2 commits into
Marias03 wants to merge 2 commits into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #492
Problem
When browsing the v2 docs and searching, results redirect to v3 pages instead of staying on v2.
Root Cause
The
DocSearchcomponent was not filtering Algolia results by version, returning results from all versions regardless of which version the user was browsing.Changes
getVersionedUrlhelper function/docs/v2/were being double-replacedsearchParameterswithfacetFiltersto scope Algolia results to the active versionHitcomponent propssearchWrapperandversionBadge